chore: refactor build system to use PCRE2 #3383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzipi
approved these changes
May 15, 2025
theseion
requested changes
May 16, 2025
Co-authored-by: Max Leske <[email protected]>
|
theseion
approved these changes
May 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR refactors the build system and the relevant source files to make the PCRE2 library as default. If you wish to continue building with the legacy PCRE library, you must explicitly specify it using the following command:
configure
--with-pcre. Without that the default will be PCRE2.The PR also changes the GH worfklow build matrix.
why
Old PCRE library is deprecated, it's time to change to PCRE2.
references
See the same change in v3.
This PR is based on #3345, but that wasn't finished.